Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable PWD reporting for iTerm2 #9955

Merged
merged 1 commit into from Aug 14, 2023
Merged

Conversation

gpanders
Copy link
Contributor

Description

iTerm2 supports reporting PWD changes via OSC 7 (and has for quite some time). Remove the TODO comment and enable OSC 7 on iTerm2.

I am not sure why this was left as a TODO for so long. I searched the issue tracker, but didn't find anything.

TODOs:

  • User-visible changes noted in CHANGELOG.rst

@faho faho added enhancement macos macOS-specific issue labels Aug 14, 2023
@faho faho added this to the fish 3.7.0 milestone Aug 14, 2023
@faho faho merged commit 69ef51f into fish-shell:master Aug 14, 2023
6 of 7 checks passed
@faho
Copy link
Member

faho commented Aug 14, 2023

Merged, thanks!

I am not sure why this was left as a TODO for so long. I searched the issue tracker, but didn't find anything.

The simple truth is that we have a bunch of macos-specific issues that we could use help with.

I can't really work on them because I don't have a mac.

@gpanders gpanders deleted the iterm-osc-7 branch August 14, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement macos macOS-specific issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants