Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added styling for Stories tab #17

Merged
merged 1 commit into from
Oct 29, 2013
Merged

Added styling for Stories tab #17

merged 1 commit into from
Oct 29, 2013

Conversation

ddrury
Copy link
Contributor

@ddrury ddrury commented Oct 26, 2013

As per bug #1244739. I've modified stories tab module.php to use existing classes for theme colouring and added specific classes to set margins etc.

@fisharebest
Copy link
Owner

The CSS changes for the webtrees theme include a block that is commented out. Is this intended?

I don't see where these elements are used:

#stories h2, #stories h3, #stories h4, #stories h5

Is it in the user-generated content?

@ddrury
Copy link
Contributor Author

ddrury commented Oct 29, 2013

Yes to both

I felt that for both heading and paragraph tags a bit of spacing made
the story look a bit better, however, for the webtrees theme sufficient
spacing is provided by something else in the css (I didn't investigate).
However as I said in the bug report, I guess it'll be impossible to
foresee everything that is likely to get put into the story (tables,
lists ...)

Regards
David
Please consider the environment before printing this e-mail

------ Original Message ------
From: "Greg Roach" notifications@github.com
To: "fisharebest/webtrees" webtrees@noreply.github.com
Cc: "David Drury" david@drury.me.uk
Sent: 29/10/2013 11:12:59
Subject: Re: [webtrees] Added styling for Stories tab (#17)

The CSS changes for the webtrees theme include a block that is
commented out. Is this intended?

I don't see where these elements are used:

#stories h2, #stories h3, #stories h4, #stories h5
Is it in the user-generated content?


Reply to this email directly or view it on GitHub.

fisharebest added a commit that referenced this pull request Oct 29, 2013
Added styling for Stories tab
@fisharebest fisharebest merged commit 2c14971 into fisharebest:master Oct 29, 2013
@kexuebin kexuebin mentioned this pull request May 20, 2019
@ricklach ricklach mentioned this pull request Jul 11, 2019
@makitso makitso mentioned this pull request Aug 11, 2019
This was referenced Aug 25, 2019
@ghost ghost mentioned this pull request Aug 9, 2020
@webtrees-pesz webtrees-pesz mentioned this pull request Aug 18, 2023
@makitso makitso mentioned this pull request Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants