Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot accept changes in HEAD #3269

Closed
hartenthaler opened this issue May 19, 2020 · 3 comments
Closed

Cannot accept changes in HEAD #3269

hartenthaler opened this issue May 19, 2020 · 3 comments
Labels
cannot reproduce Cannot recreate the error

Comments

@hartenthaler
Copy link

hartenthaler commented May 19, 2020

After updating to 2.0.4 I can click again at the tree management control page on the indicated 2 submitters of a tree (with the name "alecia"). No error message anymore, this problem is solved. Thank you! Then I deleted one of the two SUBM records. This is ok.

2020-05-19 13:04:03 edit Delete: SUBM X221 87.173.222.178 hermann alecia

Now I searched for HEAD, this opens the HEAD record. I can see that there are still links to two SUBM records, one is ok, the second one links to the just deleted record @x221@. Maybe this is bug #1. Now I deleted this link in HEAD. But when I try to accept this change, it is not possible (illegal GEDCOM record) (bug #2). What is irritating for me: the first log entry contains " | hermann | alecia", the error message contains at the end "| hermann | <none>".

2020-05-19 13:06:42 error Ungültiger GEDCOM-Datensatz<pre>0 HEAD 1 SOUR webtrees 2 NAME webtrees 2 VERS 1.7.16 1 DEST DISKETTE 1 DATE 16 JAN 2020 2 TIME 19:43:22 1 GEDC 2 VERS 5.5.1 2 FORM Lineage-Linked 1 CHAR UTF-8 1 FILE alecia 1 SUBM @sub1@ </pre> …/app/Functions/FunctionsImport.php:1078 #0 …/app/Services/PendingChangesService.php(87): Fisharebest\Webtrees\Functions\FunctionsImport::updateRecord('0 HEAD\r\n1 SOUR ...', Object(Fisharebest\Webtrees\Tree), false) #1 …/app/Http/RequestHandlers/PendingChangesAcceptRecord.php(72): Fisharebest\Webtrees\Services\PendingChangesService->acceptRecord(Object(Fisharebest\Webtrees\Header)) #2 …/app/Http/Middleware/WrapHandler.php(83): Fisharebest\Webtrees\Http\RequestHandlers\PendingChangesAcceptRecord->handle(Object(Nyholm\Psr7\ServerRequest)) #3 …/vendor/oscarotero/middleland/src/Dispatcher.php(136): Fisharebest\Webtrees\Http\Middleware\WrapHandler->process(Object(Nyholm\Psr7\ServerRequest), Object(Middleland\Dispatcher)) #4 …/modules_v4/faces/src/Modules/FacesModule.php(82): Middleland\Dispatcher->handle(Object(Nyholm\Psr7\ServerRequest)) #5 …/vendor/oscarotero/middleland/src/Dispatcher.php(136): UksusoFF\WebtreesModules\Faces\Modules\FacesModule->process(Object(Nyholm\Psr7\ServerRequest), Object(Middleland\Dispatcher)) #6 …/modules_v4/vesta_research_suggestions/ResearchSuggestionsModule.php(221): Middleland\Dispatcher->handle(Object(Nyholm\Psr7\ServerRequest)) #7 …/vendor/oscarotero/middleland/src/Dispatcher.php(136): Cissee\Webtrees\Module\ResearchSuggestions\ResearchSuggestionsModule->process(Object(Nyholm\Psr7\ServerRequest), Object(Middleland\Dispatcher)) #8 …/app/Module/HitCountFooterModule.php(157): Middleland\Dispatcher->handle(Object(Nyholm\Psr7\ServerRequest)) #9 …/vendor/oscarotero/middleland/src/Dispatcher.php(136): Fisharebest\Webtrees\Module\HitCountFooterModule->process(Object(Nyholm\Psr7\ServerRequest), Object(Middleland\Dispatcher)) #10 …/app/Http/Middleware/AuthModerator.php(57): Middleland\Dispatcher->handle(Object(Nyholm\Psr7\ServerRequest)) #11 …/vendor/oscarotero/middleland/src/Dispatcher.php(136): Fisharebest\Webtrees\Http\Middleware\AuthModerator->process(Object(Nyholm\Psr7\ServerRequest), Object(Middleland\Dispatcher)) #12 …/app/Http/Middleware/CheckCsrf.php(75): Middleland\Dispatcher->handle(Object(Nyholm\Psr7\ServerRequest)) #13 …/vendor/oscarotero/middleland/src/Dispatcher.php(136): Fisharebest\Webtrees\Http\Middleware\CheckCsrf->process(Object(Nyholm\Psr7\ServerRequest), Object(Middleland\Dispatcher)) #14 …/vendor/oscarotero/middleland/src/Dispatcher.php(118): Middleland\Dispatcher->handle(Object(Nyholm\Psr7\ServerRequest)) #15 …/app/Http/Middleware/Router.php(133): Middleland\Dispatcher->dispatch(Object(Nyholm\Psr7\ServerRequest)) #16 …/vendor/oscarotero/middleland/src/Dispatcher.php(136): Fisharebest\Webtrees\Http\Middleware\Router->process(Object(Nyholm\Psr7\ServerRequest), Object(Middleland\Dispatcher)) #17 …/app/Http/Middleware/BootModules.php(62): Middleland\Dispatcher->handle(Object(Nyholm\Psr7\ServerRequest)) #18 …/vendor/oscarotero/middleland/src/Dispatcher.php(136): Fisharebest\Webtrees\Http\Middleware\BootModules->process(Object(Nyholm\Psr7\ServerRequest), Object(Middleland\Dispatcher)) #19 …/app/Http/Middleware/LoadRoutes.php(76): Middleland\Dispatcher->handle(Object(Nyholm\Psr7\ServerRequest)) #20 …/vendor/oscarotero/middleland/src/Dispatcher.php(136): Fisharebest\Webtrees\Http\Middleware\LoadRoutes->process(Object(Nyholm\Psr7\ServerRequest), Object(Middleland\Dispatcher)) #21 …/app/Http/Middleware/UseTransaction.php(45): Middleland\Dispatcher->handle(Object(Nyholm\Psr7\ServerRequest)) #22 .... 87.173.222.178 hermann <none>
@fisharebest
Copy link
Owner

But when I try to accept this change, it is not possible (illegal GEDCOM record) (bug #2).

I cannot reproduce this.

I add a SUBM link in the header.
I accept the change.
I delete the SUBM link in the header.
I accept the change.

@fisharebest fisharebest added the cannot reproduce Cannot recreate the error label May 19, 2020
@hartenthaler
Copy link
Author

You are right. I just tried it again with two other of the six trees. It is working perfectly there. It does not work with two other trees. So I have to check what is special with them.

@fisharebest
Copy link
Owner

There have been lots of updates to the handling of HEAD/SUBM records since this issue was opened.

I guess the problem is now fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cannot reproduce Cannot recreate the error
Projects
None yet
Development

No branches or pull requests

2 participants