Prevent page jumping to top when clicking on 'request new password' link...

[JustCarmen]

Hi Greg,

I think this one is clear. A little change to prevent the page jumping to top when clicking on the 'request new password' link. This happens mostly on the login block on the homepage because the screen is larger and it is more likely that someone has scrolled down a bit before clicking on the link. But I also changed the same function in the login form.

[fisharebest]

Another solution is to replace

<a href="#" id="xxx">click me</a>

with

<span id="xxx">click me</span>

[JustCarmen]

I think that one is even better. Shall I change it?

[mnoorenberghe]

No, that would be wrong semantically. Links should be implemented as <a> elements or you lose a lot of browser behaviour.

[fisharebest]

It is not really a link. We are not navigating anywhere. Semantically, would

<button></button>

be better?

The HTML5 spec says that href is optional. http://dev.w3.org/html5/markup/a.html#placeholder-hyperlink

<a id="xxx">click me</a>

I have not seen this before.

[mnoorenberghe]

True, I forgot this was on one page now. I guess I still prefer <a> since it inherits the style for links and having more than one button below the login form would be somewhat confusing as people may think the added button would require a username to be typed in the <input>.

[fisharebest]

If we switch to bootstrap as our CSS framework, we could use something like

<button class="btn btn-link"></button>