Bug#1222698 fix and enhanced note display #22
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 3, 2019
This was referenced May 5, 2019
This was referenced May 13, 2019
Closed
Closed
Closed
This was referenced Aug 25, 2019
Closed
This was referenced Oct 7, 2019
This was referenced Oct 20, 2019
Closed
Closed
This was referenced May 5, 2020
ghost
mentioned this pull request
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shifted loading of GEDFact_assistant/css/cens_style.css from function formatCensusNote() to the theme header.php as the note css is required in a number of places. Also took opportunity to amend code in function print_note_record() to remove need for a < br > in the note text to act as a marker for when the header line is to be turned into a link (so display is consistent everywhere) also picked up potential logic error (call getNote() for a null WT_Note) and corrected display of shared notes created outside census assistant
Of course a simpler solution to the css loading may be to put the relevant lines (.note_*) into each theme css file