Bug #1222698 fix and other note styling fixes

[ddrury]

Greg, I sent you an email with a few questions about this. I've adopted the simple approach here.

Shifted note styles from GEDFact_assistant/css/cens_style.css to the themes as they are required in a number of places. Also recoded function print_note_record() to remove need for a < br > in the note text to act as a marker for when the header line is to be turned into a link (allows consistency of display), fixed potential logic error that permitted a call to getNote() with a null record, and replaced "\n" chars with "< br >" for notes that were created outside the census assistant - this identified that the regex in function formatCensusNote() was leaving leading/trailing "\n" chars for preamble, postamble & data sections. Fixed by the simple expedient of trimming them!

[fisharebest]

I have added some markup and styling for census-assistant generated tables.

I've used CSS instead of nl2br to preserve line-breaks.

I've fixed some issues where the first line wasn't always being turned into a link.

Does this fix all the issues?

[ddrury]

Greg,

Thanks, very clever, for my part I'd add text-align:left to the
table.table-census-assistant th style, but that's probably a personal
preference.

Regards
David
Please consider the environment before printing this e-mail

------ Original Message ------
From: "Greg Roach" notifications@github.com
To: "fisharebest/webtrees" webtrees@noreply.github.com
Cc: "David Drury" david@drury.me.uk
Sent: 03/11/2013 09:20:27
Subject: Re: [webtrees] Bug #1222698 fix and other note styling fixes
(#23)

I have added some markup and styling for census-assistant generated
tables.

I've used CSS instead of nl2br to preserve line-breaks.

I've fixed some issues where the first line wasn't always being turned
into a link.

Does this fix all the issues?

—
Reply to this email directly or view it on GitHub.

[ddrury]

Just noticed a typo, in functions_print.php line 410 you refer to $nid - I think you mean $note as $nid is undefined

[ddrury]

Also line 456, I think should start $first_line = ... (not $text =)

[fisharebest]

FYI, the first of this is in some unreachable code, so I've removed it.

Thanks.