Googlemaps flags: Countries and States dropdownmenu not working. #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The change looks correct, but how do I test it? (I don't use this feature. I installed the country flags, assigned one to a country. I see no change to the display or behaviour..) |
|
You only see this behaviour if you have installed country specific flags. Attached two images. The second one should be shown by using the dropdown menu. But in the current code clicking on a country from the dropdown menu has zero effect, you just stay on the first popup. |
fisharebest
added a commit
that referenced
this pull request
Nov 2, 2013
Googlemaps flags: Countries and States dropdownmenu not working.
|
OK - thanks. |
This was referenced May 3, 2019
This was referenced May 5, 2019
This was referenced May 13, 2019
Closed
Closed
Closed
This was referenced Aug 25, 2019
Closed
This was referenced Oct 7, 2019
Closed
This was referenced May 5, 2020
ghost
mentioned this pull request
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dropdown menu for countries and states in the flags popup screen wasn't working since 1.5.0 dev. I got things working by changing the WT_filter::post command to a WT_filter::get command.