medialist.php - multiple validation errors

[JustCarmen]

Hi Greg,

I have made the medialist page html valid. Therefore I had to change multiple files and stylesheets. I hope you will accept the changes.

[fisharebest]

I don't think this change is correct. The list of folders is permitted to have an empty entry. For example, if you have 3 media files:

alpha.jpg
foo/beta.jpg
foo/gamma.jpg

Then the list of folders will be array('', 'foo'). Selecting the first entry will give alpha.jpg and selecting the second will give beta.jpg and gamma.jpg

[fisharebest]

If the list of folders is empty (i.e. all media objects are in the top-level folder), then perhaps we need to hide the list of folder?

[JustCarmen]

According to W3C the option value could not be empty:

W3C: "Element option without attribute label must not be empty."

That's why I choose to set the Media directory name as first option. A second reason for this is that I think it is confusing for visitors that the first option is blank while it can have items.

I agree with you that if the list of folders is empty then we could hide the folder list. But this is only possible if the media items are loaded immediately when clicking the menu link. Currently this is not the case.

[fisharebest]

Hi Carmen - sorry it has taken me so long to find the time to look at this.

It seems mostly right, but I have a few comments...

[JustCarmen]

Greg, no problem. I know you are very busy and this was not something with high priority. But it was something that bothers me for a while. In my own theme I use some jquery to get rid of the multiple id's for example. But it really should be changed in the core, so thats why I decided to update the code myself.

I wait for your answers and then I can update the code to make the improvements if you wish.

[fisharebest]

I've merged this change. I've also made a few other changes to medialist. If I have missed or broken anything, let me know!