Proposed fixes to sitemap.php #39
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ddrury
commented
Nov 19, 2013
ddrury
commented
- Explicitly set the action parameter for the form. (fixes Bug #1252278)
- WT_Filter::postBool returns null if the posted variable doesn't exist (maybe use FILTER_NULL_ON_FAILURE flag?) which is the case if the checkbox is unchecked. This then means that WT::Tree->preference does a get not a set.
- When setting a gedcom preference, although the database is updated the cached value isn't
1. Explicitly set the action parameter for the form. 2. WT_Filter::postBool returns null if the posted variable doesn't exist (maybe use FILTER_NULL_ON_FAILURE flag?) which is the case if the checkbox is unchecked. This then means that WT::Tree->preference does a get not a set. 3. When setting a gedcom preference, although the database is updated the cached value isn't
|
It is probably better to change WT_Filter::postBool() to return a boolean - to match the function that it replaced. The fix for 1252278 looks good. I'm not sure we need to add the HTML entities to the URL. We already encode it (rawurlencode) and pass this as a (single) parameter to the google/bing submission formts. Am I missing something? |
This was referenced Oct 17, 2018
This was referenced May 3, 2019
This was referenced May 5, 2019
This was referenced May 13, 2019
Closed
Closed
Closed
This was referenced Oct 7, 2019
Closed
This was referenced May 5, 2020
ghost
mentioned this pull request
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.