Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of the http:// scheme #4960

Closed
wants to merge 0 commits into from
Closed

Update of the http:// scheme #4960

wants to merge 0 commits into from

Conversation

michael-van-den-berg
Copy link

Replace the http:// scheme to https:// scheme. Except from the location where it is not needed or where no SSL Certificate is supported.

@fisharebest
Copy link
Owner

Some of these changes are good (thanks!) - but not all of them.

  • some sites (e.g. http://www.phpgedview.net) do not appear to have a site at https
  • the minified files *.min.css do not need to be changed. They will be updated automatically from the source *.css files whenever they are next rebuilt.
  • as far as I can tell, the xlmns attribute in .xml files should not be changed. See Why does xmlns use http not https? w3c/svgwg#738
  • vendor files (ckeditor) should not be changed as they will be overwritten when we upgrade. Perhaps create a PR for the upstream project?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants