Tidy up jQuery modal dialog functions #60
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helpDialog() now requests data in json format (cuts calls to help_text.php from two to one). modalNotes() should probably be renamed to something like modalDialog to more accurately reflect it's purpose
|
Oops, just noticed there is already a modalDialog function (which is set to not modal but then appears to mimic one!) |
|
I'll resubmit this as I've rationalized things a bit more |
Closed
This was referenced Oct 12, 2019
This was referenced May 5, 2020
ghost
mentioned this pull request
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
helpDialog() now requests data in json format (cuts calls to help_text.php from two to one). modalNotes() should probably be renamed to something like modalDialog to more accurately reflect it's purpose