jQuery dialog tidy up code in webtrees1.5.1.js

[ddrury]

No description provided.

[ddrury]

Rationalize code around the modal dialog functionality. Help dialog loads data from help_text.php by jQuery.getJSON thus cutting calls from two to one.

[ddrury]

Clicked the close button by mistake!! so reopened

[fisharebest]

The change to the help dialog (to use a JSON response) is a good idea.

However, you've also made lots of other "clean up" changes at the same time. These make it difficult to review/accept the actual change, as I think these other changes have some errors.

The first cleanup change is this:

  function closePopupAndReloadParent(url) {
   if (parent.opener) {
-    if (url == null || url == "") {
+    if (url === null || url === "") {

This is some old/bad code to detect an optional parameter. If called with no argument, url is undefined. This passes the original test, but not the replacement text. A better fix might be something like:

  if (typeof url === 'undefined') {

Also, at the end of the file, some UTF8 characters are lost. Perhaps your text editor does not handle UTF8 characters? (Meanwhile, I'll replace them with escape sequences...)

Now, patches that simply tidy up code are welcome - but one change per patch makes it much easier to review/manage/accept/etc. Can you submit a separate patch with just the help-dialog changes? Thanks.