feat: add slippery tile. #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zicklag
reviewed
Mar 3, 2023
There was a problem hiding this comment.
This works great! I pushed a minor update that adds the slippery and slippery seaweed to the editor.
I'm fine merging this for now if you don't want to do this yet, but I was thinking that it'd be good to add a per-body friction option to the physics instead of the global friction parameter we have today.
Then, instead of adding the slipperyness logic to the player controller, we could cause the slippery elements to cause anything colliding with them to have a decreased friction, that would be re-set to normal when they stop colliding.
That would make everything slip on it, including items.
But I'm fine merging this now and just opening an issue for future work if you'd rather do that.
…t to an `Option<f32>`. I think this makes the proper use of the setting more clear. Also added a doc comment.
zicklag
reviewed
Mar 20, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.