Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: a bug fix - ai players being controlled by second player keys #721

Merged
merged 3 commits into from Mar 15, 2023
Merged

fix: a bug fix - ai players being controlled by second player keys #721

merged 3 commits into from Mar 15, 2023

Conversation

lvllvl
Copy link
Contributor

@lvllvl lvllvl commented Mar 14, 2023 •
edited by zicklag

  1. Tested both online demo and launched game from my terminal to see how I could control ai player. Generally it was through the jump key, and sometimes the left and right keys, but to a lesser extent.
  2. Updated session.rs line 151 to stop receiving user input.

Does this project require tests being added to make sure the code is correct / stable?

If so I can try and add that to my PR. Please lmk if any additional changes are required.

Thanks!

Fixes #712.

@lvllvl lvllvl changed the title changed session.rs so ai player cannot be controled. BUG FIX: changed session.rs so ai player cannot be controled. Mar 14, 2023
@lvllvl lvllvl changed the title BUG FIX: changed session.rs so ai player cannot be controled. Fix ai players being controlled by second player keys Mar 14, 2023
@lvllvl lvllvl changed the title Fix ai players being controlled by second player keys Fix: ai players being controlled by second player keys Mar 15, 2023
@lvllvl lvllvl changed the title Fix: ai players being controlled by second player keys fix: a bug fix - ai players being controlled by second player keys Mar 15, 2023
zicklag
zicklag approved these changes Mar 15, 2023
View reviewed changes
Copy link
Member

@zicklag zicklag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks!

Right now we don't have any testing infrastructure setup so this should be good.

@zicklag zicklag added this pull request to the merge queue Mar 15, 2023
Merged via the queue into fishfolk:main with commit 15aed99 Mar 15, 2023
8 checks passed
@lvllvl lvllvl deleted the ai_change branch March 15, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zicklag zicklag zicklag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't Let Second Player Controls Control AI Players
2 participants
@lvllvl @zicklag