Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sync sprite color and attachments. #738

Merged
merged 3 commits into from Mar 27, 2023

Conversation

bayou-brogrammer
Copy link
Contributor

  • If invincibility is active, have the player breathe slightly with their alpha
Peek.2023-03-25.14-25.mp4

- If invincibility is active, have the player breathe slightly with their alpha
@bayou-brogrammer
Copy link
Contributor Author

@zicklag should be good for a review now. I did some extra tidying with moving math utils and functions into a util module. I also created a globals module for us to store constants and static variables.

@bayou-brogrammer
Copy link
Contributor Author

The end result:

Peek.2023-03-25.10-40.mp4

Copy link
Member

@zicklag zicklag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One spelling fix, and otherwise it looks good!

Hey, and you have a negative line diff!

core/src/globals.rs Outdated Show resolved Hide resolved
@bayou-brogrammer
Copy link
Contributor Author

@zicklag ready

@zicklag zicklag added this pull request to the merge queue Mar 27, 2023
Merged via the queue into fishfolk:main with commit f3ddaf3 Mar 27, 2023
8 checks passed
@bayou-brogrammer bayou-brogrammer deleted the feat/sprite-alpha branch March 28, 2023 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants