refactor: editor to use map_interface #771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion; need to test;
…nto editor_refactor
AustinHellerRepo
changed the title
zicklag
requested changes
Apr 29, 2023
There was a problem hiding this comment.
Awesome, looking great, thanks!
Regarding the name, I think I like MapManger, which also has a slight precendent in Jumpy with the SessionManager existing already.
Unless you don't like that name, I'm not super picky. :D
Regarding the macro, could you move it to core/src/utils.rs ( or maybe core/src/utils/macros.rs if you think that seems appropriate ), and then in core/src/lib.rs we can add a #[macro_use] import for utils so that we can use the macro throughout the crate.
Then we can also remove macro definition from collisions.rs.
…_system_param macro; updated collision.rs to use centralized macro;
|
I've updated the struct name and centralized the macro. Please let me know if you would like any other changes. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The player interactions handled by the editor.rs file have been refactored out into a separate struct so that future enhancements to the editor may use this refactored code instead of copying large sections of it if similar functionality is used (and will be used as part of my next update to allow for map randomization).
An example of how this refactoring will help is when large parts of the map will be updated with one button click. Now simply calling map_interface.set_tile multiple times is possible instead of copy-pasting all of the code previously contained in the SetTile match-case.