Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper camera logic, and new player movement limitations #62

Merged
merged 11 commits into from
Jul 11, 2022

Conversation

64kramsystem
Copy link
Member

@64kramsystem 64kramsystem commented Jul 10, 2022

Closes the first task of #29; the camera has now a proper logic, typical of beat 'em ups.

Boss-related logic is not yet implemented, since there are no bosses yet 馃槅

@64kramsystem 64kramsystem force-pushed the limit_players_distance branch 2 times, most recently from bcc0159 to 7ba5b3d Compare July 10, 2022 19:49
@64kramsystem
Copy link
Member Author

Ok, this is ready for review etc. Note that this logic has severe limitations. This is intentional; fully implementing the new camera logic requires extensive changes, which IMO should not be applied in a single PR.

@64kramsystem 64kramsystem changed the title Limit players distance Limit players distance and left movement boundary Jul 10, 2022
@64kramsystem 64kramsystem mentioned this pull request Jul 10, 2022
3 tasks
assets/default.game.yaml Outdated Show resolved Hide resolved
src/movement.rs Outdated Show resolved Hide resolved
src/movement.rs Outdated Show resolved Hide resolved
src/movement.rs Outdated Show resolved Hide resolved
src/movement.rs Outdated Show resolved Hide resolved
src/movement.rs Show resolved Hide resolved
@64kramsystem
Copy link
Member Author

Addressed all of them. Generalized the forward (right) limit to any number of players.

Note that the limitation on the backward (left) behavior is not relative to the rightmost player position, instead, it's based on the boundary. This can make the distance grow more than wanted. This is intended, since the limitation logic will need to be updated along with the new camera logic.

@64kramsystem
Copy link
Member Author

Extra note: I'm using a feature of the latest stable Rust (f32#total_cmp).

@64kramsystem 64kramsystem changed the title Limit players distance and left movement boundary Proper camera logic, and new player movement limitations Jul 10, 2022
@64kramsystem
Copy link
Member Author

64kramsystem commented Jul 10, 2022

Since nobody was looking, I've added the new camera commits 馃槵 馃槀 This now fully closes the first task of #29.

@64kramsystem 64kramsystem requested a review from odecay July 10, 2022 23:11
@64kramsystem
Copy link
Member Author

Re-requested review, due to new commits with the new camera logic.

@odecay odecay merged commit 38331b0 into fishfolk:master Jul 11, 2022
@64kramsystem 64kramsystem deleted the limit_players_distance branch July 11, 2022 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants