Storage abstraction #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
64kramsystem
approved these changes
Jul 13, 2022
|
And look at that, an update to the Justfile resulted in CI finishing in only 11 seconds! |
WASM build was failing because we renamed the crate to punchy.
This will allow us to implement save data and persistent settings such as input mapping.
Co-authored-by: Saverio Miroddi <saverio.pub2@gmail.com>
zicklag
force-pushed
the
storage-abstraction
branch
from
526579b
to
8dcdecf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #74.
This implements a
Storageresource that can be used to access save data, with the details of file IO and browser local storage completely abstracted away to simple string keys andSerialize + Deserializevalues.Data is stored in YAML in the user's operating system's data dir on native, and in local storage in the browser.
Currently the abstraction isn't used anywhere, but I did test it with a simple debug gui locally.
I'll be using it to make the input mapping menu next.