This repository has been archived by the owner on Mar 7, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 117
Implement seek on FileOperations #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex
force-pushed
the
ll_seek
branch
2 times, most recently
from
August 5, 2019 02:05
65826da
to
d098fc6
Compare
geofft
suggested changes
Aug 5, 2019
(LGTM otherwise) |
The kernel seems to just use |
Updated to make |
alex
force-pushed
the
ll_seek
branch
2 times, most recently
from
August 20, 2019 00:51
4cdf5c2
to
597b464
Compare
Quoting this in the main comment thread so it doesn't get lost in line-item review.
OK, the answer is miserable:
I think the right thing to do here is to punt on handling |
geofft
approved these changes
Aug 25, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #110