This repository has been archived by the owner on Mar 7, 2021. It is now read-only.
Introduce a less verbose, type safe, idiom for C strings. #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex
force-pushed
the
c-str-idiom
branch
2 times, most recently
from
8cfa2a8
to
89dac48
Compare
geofft
reviewed
Aug 20, 2019
| impl CStr { | ||
| pub fn new<'a>(data: &'a str) -> &'a CStr { | ||
| if data.bytes().position(|b| b == b'\x00') != Some(data.len() - 1) { | ||
| panic!("CStr must contain a single NUL byte at the end"); |
There was a problem hiding this comment.
Hm, is it worth having two versions of this, one internal for cstr!(I think it needs to be #[doc(hidden)] pub) and one actually public that returns EINVAL instead of panicking?
There was a problem hiding this comment.
As soon as we have another use case for this :-)
Also, cstr doesn't have a way to statically verify these things, so it can't bypass them at runtime either.
There was a problem hiding this comment.
TBH I'd be okay with this being an unsafe function that assumes there's a trailing NUL, to get rid of the runtime cost. cstr! enforces it so it can safely call it.
geofft
approved these changes
Aug 20, 2019
alex
force-pushed
the
c-str-idiom
branch
2 times, most recently
from
0bf857f
to
5237817
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16