-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RTC-208] Add server socket tests #33
Conversation
Codecov Report
@@ Coverage Diff @@
## main #33 +/- ##
==========================================
+ Coverage 80.76% 89.12% +8.35%
==========================================
Files 31 32 +1
Lines 364 377 +13
==========================================
+ Hits 294 336 +42
+ Misses 70 41 -29
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
e9ff86a
to
8418250
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be possible to also test peer/component crashes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, we are not able to get engine endpoint pid at the moment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would wrap tests about connecting to the server (valid/invalid token, no peer etc.) in one describe (describe "connecting to server"
?) and the two last test in describe "sends a message"
or something similar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBH, I don't see any benefits from using describe here. We will just introduce more nesting 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think is creates nice visual distinction between connection tests, receiving information from socket tests etc., but I don't care about it that much.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we mentioned offline, it's probably possible to move some tests from peer socket unit tests here.
a992ed5
to
7282f9e
Compare
93591ca
to
3cb9587
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍, but maybe it would be nice to add a comment somewhere why we don't test peer/component crashes (membrane_rtc_engine
limitations).
No description provided.