Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve babel parse speed #378

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Improve babel parse speed #378

wants to merge 4 commits into from

Conversation

fisker
Copy link
Owner

@fisker fisker commented May 2, 2020

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/pr-XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

Try the playground for this PR

@pull-assistant
Copy link

pull-assistant bot commented May 2, 2020

Score: 0.48

Best reviewed: with all changes


Optimal code review plan (4 commits squashed)

Improve babel parse ... ... Fix tests

Squashed 4 commits:

Powered by Pull Assistant. Last update 9bf8f0a ... e0f70e7. Read the comment docs.

@todo
Copy link

todo bot commented May 2, 2020

this is not enabled

// TODO: this is not enabled
// {
// name: "exportNamespaceFrom",
// test(text) {
// return text.includes("export") && text.includes("as") && text.includes("from");
// },


This comment was generated by todo based on a TODO comment in 7fc3435 in #378. cc @fisker.

@todo
Copy link

todo bot commented May 2, 2020

enable this

// TODO: enable this
// {
// name: "jsx",
// test(text) {
// return /<\/|\/>/.test(text);
// },


This comment was generated by todo based on a TODO comment in 7fc3435 in #378. cc @fisker.

Base automatically changed from master to main January 25, 2021 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant