Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor comment attach #953

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open

Refactor comment attach #953

wants to merge 24 commits into from

Commits on Nov 21, 2020

  1. Refactor comment attach

    @fisker
    fisker committed Nov 21, 2020
    Configuration menu
    Copy the full SHA
    be7edf1 View commit details
    Browse the repository at this point in the history

  2. Update attach logic

    @fisker
    fisker committed Nov 21, 2020
    Configuration menu
    Copy the full SHA
    091957b View commit details
    Browse the repository at this point in the history

  3. Put store into options

    @fisker
    fisker committed Nov 21, 2020
    Configuration menu
    Copy the full SHA
    073d11c View commit details
    Browse the repository at this point in the history

  4. Refactor print functions

    @fisker
    fisker committed Nov 21, 2020
    Configuration menu
    Copy the full SHA
    8dc72ff View commit details
    Browse the repository at this point in the history

  5. Fix json

    @fisker
    fisker committed Nov 21, 2020
    Configuration menu
    Copy the full SHA
    777d80e View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2020

  1. Merge branch 'master' into comment-attach-refactor-2 

    # Conflicts:
#	src/language-js/comments.js
    @fisker
    fisker committed Nov 26, 2020
    Configuration menu
    Copy the full SHA
    794ec93 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2020

  1. Merge branch 'master' into comment-attach-refactor-2 

    # Conflicts:
#	src/main/comments.js
    @fisker
    fisker committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    a56e917 View commit details
    Browse the repository at this point in the history

  2. Fix breakTies

    @fisker
    fisker committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    b9edd77 View commit details
    Browse the repository at this point in the history

  3. Remove debug info

    @fisker
    fisker committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    31681fe View commit details
    Browse the repository at this point in the history

  4. don't handle ignore

    @fisker
    fisker committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    952882e View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2020

  1. Fix multiparser

    @fisker
    fisker committed Dec 3, 2020
    Configuration menu
    Copy the full SHA
    30877c4 View commit details
    Browse the repository at this point in the history

  2. Fix typing

    @fisker
    fisker committed Dec 3, 2020
    Configuration menu
    Copy the full SHA
    9ac8c70 View commit details
    Browse the repository at this point in the history

  3. Fix missing marker

    @fisker
    fisker committed Dec 3, 2020
    Configuration menu
    Copy the full SHA
    6c3e6aa View commit details
    Browse the repository at this point in the history

  4. Refactor js related functions

    @fisker
    fisker committed Dec 3, 2020
    Configuration menu
    Copy the full SHA
    99a91b7 View commit details
    Browse the repository at this point in the history

  5. Allways call comment.attach to ensure commentsStore exits

    @fisker
    fisker committed Dec 3, 2020
    Configuration menu
    Copy the full SHA
    c31e6ed View commit details
    Browse the repository at this point in the history

  6. Fix missing options

    @fisker
    fisker committed Dec 3, 2020
    Configuration menu
    Copy the full SHA
    0d34e15 View commit details
    Browse the repository at this point in the history

  7. Fix angular parsers

    @fisker
    fisker committed Dec 3, 2020
    Configuration menu
    Copy the full SHA
    07116d3 View commit details
    Browse the repository at this point in the history

  8. Make commentsStore optional

    @fisker
    fisker committed Dec 3, 2020
    Configuration menu
    Copy the full SHA
    515a6de View commit details
    Browse the repository at this point in the history

  9. Fix typing

    @fisker
    fisker committed Dec 3, 2020
    Configuration menu
    Copy the full SHA
    a7a5dbc View commit details
    Browse the repository at this point in the history

  10. !Stop attaching comments to node!

    @fisker
    fisker committed Dec 3, 2020
    Configuration menu
    Copy the full SHA
    8606158 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2020

  1. Fix getComments function

    @fisker
    fisker committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    c1b587c View commit details
    Browse the repository at this point in the history

  2. Fix CatchClause comments check

    @fisker
    fisker committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    204acc8 View commit details
    Browse the repository at this point in the history

  3. Pass commentType to printer.printComment

    @fisker
    fisker committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    a18b651 View commit details
    Browse the repository at this point in the history

  4. Run yarn fix

    @fisker
    fisker committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    9d30a0d View commit details
    Browse the repository at this point in the history