Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor comment attach #953

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open

Refactor comment attach #953

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
be7edf1
Refactor comment attach
fisker Nov 21, 2020
091957b
Update attach logic
fisker Nov 21, 2020
073d11c
Put store into options
fisker Nov 21, 2020
8dc72ff
Refactor print functions
fisker Nov 21, 2020
777d80e
Fix json
fisker Nov 21, 2020
794ec93
Merge branch 'master' into comment-attach-refactor-2
fisker Nov 26, 2020
a56e917
Merge branch 'master' into comment-attach-refactor-2
fisker Dec 2, 2020
b9edd77
Fix `breakTies`
fisker Dec 2, 2020
31681fe
Remove debug info
fisker Dec 2, 2020
952882e
don't handle ignore
fisker Dec 2, 2020
30877c4
Fix multiparser
fisker Dec 3, 2020
9ac8c70
Fix typing
fisker Dec 3, 2020
6c3e6aa
Fix missing marker
fisker Dec 3, 2020
99a91b7
Refactor js related functions
fisker Dec 3, 2020
c31e6ed
Allways call comment.attach to ensure commentsStore exits
fisker Dec 3, 2020
0d34e15
Fix missing `options`
fisker Dec 3, 2020
07116d3
Fix angular parsers
fisker Dec 3, 2020
515a6de
Make `commentsStore` optional
fisker Dec 3, 2020
a7a5dbc
Fix typing
fisker Dec 3, 2020
8606158
!Stop attaching comments to node!
fisker Dec 3, 2020
c1b587c
Fix `getComments` function
fisker Dec 4, 2020
204acc8
Fix `CatchClause` comments check
fisker Dec 4, 2020
a18b651
Pass `commentType` to `printer.printComment`
fisker Dec 4, 2020
9d30a0d
Run `yarn fix`
fisker Dec 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .eslintrc.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,7 @@ overrides:
- error
- file: "src/language-js/utils.js"
functions:
- hasComment
- getComments
- getAllComments
- "src/language-js/parse-postprocess.js"
- "src/language-js/parser-babel.js"
- "src/language-js/parser-meriyah.js"
Expand Down
Loading