-
Notifications
You must be signed in to change notification settings - Fork 4
Feature/app endpoints #36
base: master
Are you sure you want to change the base?
Feature/app endpoints #36
Conversation
src/types.ts
Outdated
@@ -16,3 +16,7 @@ export type Register = { | |||
password: string | |||
email: string | |||
} | |||
|
|||
export type Apps = { | |||
[property: string]: string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 Since this is mainly app names, have you considered something like AppName[]
? We will likely have an App
type in the future, so this may conflict with what one would expect from a plural of those.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That said, I’ll leave it to @icidasset and @dholms to weigh in here; they’re deeper in the TS client than I am (it’s been a while)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would do something along the lines of:
type App = { domain: string }
type Apps = Array<App> // sorted by domain
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And maybe remove the Apps
type entirely, and just use Array<App>
instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks guys for the review! I made the type changes, hopefully thats more along of the lines of what you wanted
Summary
This PR fixes/implements the following features
Added the following API requests to the sdk
Added two relevant tests & documentation.