Skip to content

Commit

Permalink
Update kubernetes versions in CI verification
Browse files Browse the repository at this point in the history
Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
  • Loading branch information
sanketsudake committed Oct 10, 2023
1 parent 56b49dc commit 0a87f5c
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 13 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/push_pr.yaml
Expand Up @@ -23,7 +23,7 @@ on:

env:
HELM_VERSION: v3.10.1
KIND_VERSION: v0.17.0
KIND_VERSION: v0.20.0

jobs:
# Job to run change detection
Expand All @@ -33,7 +33,7 @@ jobs:
strategy:
fail-fast: false
matrix:
kindversion: ["v1.19.16", "v1.20.15", "v1.21.14"]
kindversion: ["v1.23.17", "v1.25.11", "v1.27.3"]
os: [ubuntu-latest]
steps:
- name: Checkout sources
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yaml
Expand Up @@ -6,8 +6,8 @@ on:
- v2.**

env:
KIND_VERSION: v0.17.0
KIND_NODE_IMAGE_TAG: v1.19.16
KIND_VERSION: v0.20.0
KIND_NODE_IMAGE_TAG: v1.23.17

jobs:
create-draft-release:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/upgrade_test.yaml
Expand Up @@ -23,7 +23,7 @@ on:

env:
HELM_VERSION: v3.10.1
KIND_VERSION: v0.17.0
KIND_VERSION: v0.20.0

jobs:
upgrade-test:
Expand All @@ -32,7 +32,7 @@ jobs:
strategy:
fail-fast: false
matrix:
kindimage: ["kindest/node:v1.19.16"]
kindimage: ["kindest/node:v1.23.17"]
os: [ubuntu-latest]
steps:
- name: Checkout action sources
Expand Down
8 changes: 4 additions & 4 deletions .mergify.yml
Expand Up @@ -8,10 +8,10 @@ pull_request_rules:
- check-success=CodeQL-Build
- check-success=CodeQL
- check-success=lint
- check-success=upgrade-test (kindest/node:v1.19.11, ubuntu-latest)
- check-success=integration-test (v1.19.11, ubuntu-latest)
- check-success=integration-test (v1.20.7, ubuntu-latest)
- check-success=integration-test (v1.21.1, ubuntu-latest)
- check-success=upgrade-test (kindest/node:v1.23.17, ubuntu-latest)
- check-success=integration-test (v1.23.17, ubuntu-latest)
- check-success=integration-test (v1.25.11, ubuntu-latest)
- check-success=integration-test (v1.27.3, ubuntu-latest)
actions:
merge:
method: squash
6 changes: 3 additions & 3 deletions pkg/fission-cli/util/util.go
Expand Up @@ -99,15 +99,15 @@ func KubifyName(old string) string {
newName := strings.ToLower(old)

// replace disallowed chars with '-'
inv, _ := regexp.Compile("[^-a-z0-9]")
inv := regexp.MustCompile("[^-a-z0-9]")
newName = string(inv.ReplaceAll([]byte(newName), []byte("-")))

// trim leading non-alphabetic
leadingnonalpha, _ := regexp.Compile("^[^a-z]+")
leadingnonalpha := regexp.MustCompile("^[^a-z]+")
newName = string(leadingnonalpha.ReplaceAll([]byte(newName), []byte{}))

// trim trailing
trailing, _ := regexp.Compile("[^a-z0-9]+$")
trailing := regexp.MustCompile("[^a-z0-9]+$")
newName = string(trailing.ReplaceAll([]byte(newName), []byte{}))

// truncate to length
Expand Down

0 comments on commit 0a87f5c

Please sign in to comment.