Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Fix CLI drops controller URL path when querying logs #1201

Merged
merged 3 commits into from Jun 17, 2019

Conversation

moluzhang
Copy link
Contributor

@moluzhang moluzhang commented Jun 3, 2019

…er with prefix router


This change is Reviewable

@life1347
Copy link
Member

life1347 commented Jun 5, 2019

@moluzhang Thanks for the PR! I will give a test and hope we can merge it soon.

Copy link
Member

@life1347 life1347 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except two minor comments

pkg/fission-cli/logdb/influxdb.go Outdated Show resolved Hide resolved
pkg/fission-cli/logdb/influxdb.go Outdated Show resolved Hide resolved
@life1347 life1347 changed the title [bugfix] the fission services may be accessed by the ingress-controll… [bugfix] Fix CLI drops controller URL path when querying logs Jun 17, 2019
@life1347 life1347 merged commit 5445b75 into fission:master Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants