Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop unreleased features (record & replay) #1406

Merged
merged 1 commit into from Nov 13, 2019
Merged

Drop unreleased features (record & replay) #1406

merged 1 commit into from Nov 13, 2019

Conversation

life1347
Copy link
Member

@life1347 life1347 commented Nov 13, 2019

  1. The records are stored in redis which is not migratable to another cluster for the testing purposes.
  2. Some of the requests fields are not recorded.
  3. People should consider using https://github.com/buger/goreplay which is an existing mature and well-tested solution for testing purposes.

This change is Reviewable

@codecov
Copy link

codecov bot commented Nov 13, 2019

Codecov Report

Merging #1406 into master will increase coverage by 1.04%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1406      +/-   ##
==========================================
+ Coverage   30.96%   32.01%   +1.04%     
==========================================
  Files          75       68       -7     
  Lines        5903     5488     -415     
==========================================
- Hits         1828     1757      -71     
+ Misses       3836     3496     -340     
+ Partials      239      235       -4
Impacted Files Coverage Δ
pkg/router/requesthHeader.go 80% <ø> (+15.71%) ⬆️
pkg/router/functionHandler.go 37.76% <ø> (+2.24%) ⬆️
pkg/crd/crd.go 93.18% <ø> (-0.66%) ⬇️
pkg/crd/client.go 65.9% <ø> (-0.76%) ⬇️
pkg/controller/api.go 67.13% <ø> (-2.15%) ⬇️
pkg/router/router.go 11.57% <0%> (+0.18%) ⬆️
pkg/router/httpTriggers.go 31.01% <100%> (+0.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cda7e0...a0ad719. Read the comment docs.

@life1347 life1347 merged commit cf2d352 into master Nov 13, 2019
@life1347 life1347 deleted the remove-record branch November 13, 2019 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant