Validation/Mutating webhook for Fission resources #2577
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neha-Gupta1
force-pushed
the
validation
branch
from
d070530
to
b930564
Compare
sanketsudake
requested changes
Oct 27, 2022
| wLogger := logger.Named("webhook") | ||
|
|
||
| // Setup a Manager | ||
| mgr, err := manager.New(config.GetConfigOrDie(), manager.Options{ |
There was a problem hiding this comment.
Please enable metrics port here. I think we have 8080 across all components.
sanketsudake
requested changes
Oct 31, 2022
| @@ -17,30 +17,12 @@ package signals | |||
|
|
|||
There was a problem hiding this comment.
We should remove this package entirely.
neha-Gupta1
force-pushed
the
validation
branch
from
322d6b5
to
9028ea0
Compare
sanketsudake
requested changes
Oct 31, 2022
| // ValidateCreate implements webhook.Validator so a webhook will be registered for the type | ||
| func (r *Environment) ValidateCreate() error { | ||
| environmentlog.Info("validate create", "name", r.Name) | ||
| err := r.Validate() |
There was a problem hiding this comment.
We can directly return error from Validate call. Rest of code is unnecessary. Please do same changes at rest of places.
return r.Validate()
| ) | ||
|
|
||
| // log is for logging in this package. | ||
| var httptriggerlog = logf.Log.WithName("httptrigger-resource") |
There was a problem hiding this comment.
Please use GetLogger from "utils/loggerfactory" for consistency across Fission source code.
|
|
||
| // ValidateCreate implements webhook.Validator so a webhook will be registered for the type | ||
| func (r *HTTPTrigger) ValidateCreate() error { | ||
| httptriggerlog.Info("validate create", "name", r.Name) |
There was a problem hiding this comment.
Please change all info statements from debug.
| @@ -0,0 +1,84 @@ | |||
| /* | |||
There was a problem hiding this comment.
Please rename file to webhook.go
call k8s API from CLI for all resources
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added Validation/Mutating Webhooks for Fission resources. It will test all API request before CRUD on resources.
Which issue(s) this PR fixes:
Fixes #
Testing
Checklist: