Monitor specific namespaces for configmap/secret updates #2598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We all functions to refer configmap/secrets. As of now we are monitoring all namespaces for configmap and secrets and also allow cross namespace references. This fix monitors configmaps/secret updates in specific namespace. Also we ignore cross namespace references for configmap/secret updates. Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #2598 +/- ##
==========================================
- Coverage 19.78% 19.76% -0.02%
==========================================
Files 62 62
Lines 7001 7001
==========================================
- Hits 1385 1384 -1
- Misses 5510 5511 +1
Partials 106 106
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Related to #2599 |
shubham-bansal96
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We allow functions to refer configmap/secrets. We are monitoring all namespaces for configmaps and secrets and also allow cross-namespace references.
This fix monitors configmaps/secret updates in specific namespaces. Also, we ignore cross-namespace references for configmap/secret updates.
Signed-off-by: Sanket Sudake sanketsudake@gmail.com
Description
Which issue(s) this PR fixes:
Fixes #
Testing
Checklist: