Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove singleDefaultNamespace field from helm chart #2670

Merged
merged 2 commits into from Dec 14, 2022

Conversation

shubham-bansal96
Copy link
Contributor

Description

We have removed singleDefaultNamespace field from helm chart. Fission will work with both default and additional namespace(if values present in additional namespace).

Which issue(s) this PR fixes:

Fixes #

Testing

Checklist:

  • I ran tests as well as code linting locally to verify my changes.
  • I have done manual verification of my changes, changes working as expected.
  • I have added new tests to cover my changes.
  • My changes follow contributing guidelines of Fission.
  • I have signed all of my commits.

@shubham-bansal96 shubham-bansal96 added the run-old-ci To ensure backward compatibility of fission label Dec 14, 2022
@codecov
Copy link

codecov bot commented Dec 14, 2022

Codecov Report

Merging #2670 (62c7a02) into main (d52c602) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2670      +/-   ##
==========================================
- Coverage   19.15%   19.14%   -0.02%     
==========================================
  Files          65       65              
  Lines        7209     7209              
==========================================
- Hits         1381     1380       -1     
- Misses       5726     5727       +1     
  Partials      102      102              
Flag Coverage Δ
unittests 19.14% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/utils/serviceaccount.go 0.00% <ø> (ø)
pkg/utils/httpserver/server.go 55.55% <0.00%> (-5.56%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@sanketsudake sanketsudake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sanketsudake sanketsudake merged commit 3e25f47 into main Dec 14, 2022
@sanketsudake sanketsudake deleted the remove-singleDefaultNamespace-field branch December 15, 2022 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-old-ci To ensure backward compatibility of fission
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants