Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SEGFAULT issue when buildmgr failed to update package #635

Merged
merged 2 commits into from Apr 21, 2018
Merged

Fix SEGFAULT issue when buildmgr failed to update package #635

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b97289
Fix SEGFAULT issue when buildmgr failed to update package
life1347 Apr 19, 2018
f6673b0
Rollback some changes
life1347 Apr 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion buildermgr/pkgwatcher.go
View file
Open in desktop
Expand Up @@ -88,7 +88,7 @@ func (pkgw *packageWatcher) build(buildCache *cache.Cache, srcpkg *crd.Package)
if err != nil {
e := fmt.Sprintf("Error setting package pending state: %v", err)
log.Println(e)
updatePackage(pkgw.fissionClient, pkg, fission.BuildStatusFailed, e, nil)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense.

updatePackage(pkgw.fissionClient, srcpkg, fission.BuildStatusFailed, e, nil)
return
}

Expand Down