Fission metrics integration #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cherry-picked first commit from yqf metric branch
…iased to a string, but it is a new type
…d, changes to metrics-svc reflecting current state of fission
soamvasani
force-pushed
the
fission-metrics-integration
branch
from
300c07e
to
3b9f59d
Compare
|
I'm going to merge this; I'll address review comments in a follow up PR. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add prometheus metrics collection endpoints to router and executor. Add prometheus annotations to router and executor pods.
No grafana integration just yet. Let's do that in a separate change.
Fission will not install Prometheus; users can just use the regular prometheus installation methods (I tested this change with the prometheus helm chart).
Docs tracked in fission/docs.fission.io#22
[This change builds on a bunch of work from @yqf3139 and @prithviramesh, several months ago, that didn't get merged at the time.]
This change is