Skip to content

Commit

Permalink
Issue #167: Rename minimizers_list_defaults.json to fitbenchmarking_d…
Browse files Browse the repository at this point in the history
…efault_options.json
  • Loading branch information
AndrewLister-STFC committed Sep 4, 2019
1 parent 9c6d969 commit 3040567
Show file tree
Hide file tree
Showing 8 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion example_scripts/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ Here is the list of all the example scripts and the difference between them:
3. `example_runScripts_expert.py` is designed to be run once Mantid and SasView (future development) are installed. This script will benchmark all the minimizers from different softwares against various type of problem definition files.
### Example usage

For default minimizers use (which loads minimizers_list_defaults.json):
For default minimizers use (which loads fitbenchmarking_default_options.json):
`mantidpython example_runScripts.py`

Can also change the `minimizers` variable within `example_runScripts.py` to customize the minimization (see example script)
Expand Down
2 changes: 1 addition & 1 deletion example_scripts/example_runScripts.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
software_options['minimizer_options'] = custom_minimizers
else:
# Using default minimizers from
# fitbenchmarking/fitbenchmarking/minimizers_list_default.json
# fitbenchmarking/fitbenchmarking/fitbenchmarking_default_options.json
software_options['minimizer_options'] = None

# Benchmark problem directories
Expand Down
2 changes: 1 addition & 1 deletion example_scripts/example_runScripts_SasView.py
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@
software_options['minimizer_options'] = custom_minimizers
else:
# Using default minimizers from
# fitbenchmarking/fitbenchmarking/minimizers_list_default.json
# fitbenchmarking/fitbenchmarking/fitbenchmarking_default_options.json
software_options['minimizer_options'] = None


Expand Down
2 changes: 1 addition & 1 deletion example_scripts/example_runScripts_expert.py
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
software_options['minimizer_options'] = custom_minimizers
else:
# Using default minimizers from
# fitbenchmarking/fitbenchmarking/minimizers_list_default.json
# fitbenchmarking/fitbenchmarking/fitbenchmarking_default_options.json
software_options['minimizer_options'] = None

# Benchmark problem directories
Expand Down
2 changes: 1 addition & 1 deletion example_scripts/example_runScripts_mantid.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
software_options['minimizer_options'] = custom_minimizers
else:
# Using default minimizers from
# fitbenchmarking/fitbenchmarking/minimizers_list_default.json
# fitbenchmarking/fitbenchmarking/fitbenchmarking_default_options.json
software_options['minimizer_options'] = None

# Benchmark problem directories
Expand Down
2 changes: 1 addition & 1 deletion fitbenchmarking/utils/misc.py
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ def get_minimizers(software_options):
current_path = os.path.dirname(os.path.realpath(__file__))
fitbm_path = os.path.abspath(os.path.join(current_path, os.pardir))
minimizer_file = os.path.join(fitbm_path,
"minimizers_list_default.json")
"fitbenchmarking_default_options.json")
minimizers_list = json.load(open(minimizer_file))
elif isinstance(minimizer_options, str):
minimizers_list = json.load(open(minimizer_options))
Expand Down
2 changes: 1 addition & 1 deletion fitbenchmarking/utils/tests/test_misc.py
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ def get_minimizers_file(self):
utils_path = os.path.abspath(os.path.join(current_path, os.pardir))
fitbm_path = os.path.abspath(os.path.join(utils_path, os.pardir))
minimizer_json = os.path.join(fitbm_path,
"minimizers_list_default.json")
"fitbenchmarking_default_options.json")
return str(minimizer_json)

def test_getMinimizers_load_correct_minimizers_mantid_default(self):
Expand Down

0 comments on commit 3040567

Please sign in to comment.