Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default FitBenchmarking options file #167

Closed
Anders-Markvardsen opened this issue May 31, 2019 · 3 comments · Fixed by #212
Closed

Add default FitBenchmarking options file #167

Anders-Markvardsen opened this issue May 31, 2019 · 3 comments · Fixed by #212

Comments

@Anders-Markvardsen
Copy link
Contributor

Current we have minimizers_list_default.json which set the default minimizers which FitBenchmarking will be compared for each software.

As of now it reads:

{
    "mantid" : ["BFGS", "Conjugate gradient (Fletcher-Reeves imp.)",
                "Conjugate gradient (Polak-Ribiere imp.)",
                "Damped GaussNewton",
                "Levenberg-Marquardt", "Levenberg-MarquardtMD",
                "Simplex","SteepestDescent",
                "Trust Region"],
    "scipy" : ["lm", "trf", "dogbox"]
}

Simply change the name of the file to fitbenchmarking_default_options.json and update all documentation and code that previously referred to minimizers_list_default.json

@AndrewLister-STFC
Copy link
Contributor

@wathen suggested I start with #134 which mentions this in the description.

@Anders-Markvardsen, can you confirm that the documentation referenced is the GitHub wiki? I couldn't see anything on this file in there.
I can fix the results from a grep ("example_scripts/" and some values in "utils/misc.py" and "utils/tests/test_misc.py"), but if it's in other locations too, I may need a pointer.

@Anders-Markvardsen
Copy link
Contributor Author

There may not be any documentation on this setting file in the wiki yet - hence with this change preferable but optionally document that with the change in this issue we will then above a global setting files.

However as a minimum to a grep on all sort files for minimizers_list_default.json and change accordingly. Thanks and welcome

@AndrewLister-STFC
Copy link
Contributor

Since other options need to be added I should extend this so that the minimisers are a single option in the file, and are collected that way. (e.g. json.load(open(options_file))['minimizers']

wathen added a commit that referenced this issue Sep 9, 2019
…st_defaults_file

Issue #167: Rename minimizers_list_defaults.json to fitbenchmarking_default_options.json
@AndrewLister-STFC AndrewLister-STFC moved this from To do to Merge to master in 2019 framework functional improvements Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
2 participants