Issue #167: Rename minimizers_list_defaults.json to fitbenchmarking_default_options.json #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…efault_options.json
|
See issue for reason for close |
AndrewLister-STFC
force-pushed
the
167_rename_minimizers_list_defaults_file
branch
from
4f4a332
to
fa3418c
Compare
AndrewLister-STFC
force-pushed
the
167_rename_minimizers_list_defaults_file
branch
from
fa3418c
to
103a31b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Work
Renamed file as in title. Change all references to match new name.
Fixes #167
Wiki update to include documentation on the new options file in "Run Scripts" to follow after merge.
Testing Instructions
grep -r "minimizers\_list\_default" .from the root dir for the repoEXPECTED RESULT: None, this should return no entries