Implement Winliner, the speculative indirect call inliner for WebAssembly #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mbly Revert "Delete everything so I can revert this commit and have a reviewable PR adding everything" This reverts commit b878ea6.
cfallin
reviewed
Sep 21, 2023
There was a problem hiding this comment.
Looks really good overall -- nice work!
A bunch of comments below; the two correctness-relevant ones are the missing handling for Return we saw earlier, and a possible issue with name sections, I think.
Unfortunately I wasn't able to see any other issues that could lead to the crash (divergence of optimized code) with the module I sent you earlier -- it'd be nice to bottom that out before doing any releases and calling this done, though I don't want to hold the initial review on it. Happy to help pair-debug that one further if you want.
This was referenced Oct 12, 2023
|
Okay, I've either addressed everything or filed follow up issues, so I'm going to merge this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @cfallin