-
Notifications
You must be signed in to change notification settings - Fork 391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding first version that allows parsing the ssh config files for hosts #24
Adding first version that allows parsing the ssh config files for hosts #24
Conversation
I tried to address all your comments, with regards to filtering entries like * this was because my ssh config has an entry for special configuration of EC2 hosts and uses a * here to explicitly include all different possible subdomains. |
I like this approach. I had considered removing the json config entirely but this might be better. In the One of the things I noticed was the same problem I had when figuring how to construct the JSON. Dictionary containers don't honor the order of their contents. So the hosts in the config file aren't guaranteed to end up in that same order. I ended up making the hosts an array with each value being its own object. Not sure if this is the best way to do it, but I think we may want respect the order that the user sets in their config. |
For the check of the last changed date I will add this in the same way as it is done for the json file. For the order of the entries I basically extract all keys from the dictionary and sort them so the order in the menu is always alphabetically which seemed to me like the right thing to do... |
👍 Agreed. Alphabetical is good. |
Adding hosts from SSH Config so they don't need to be configured twice in the system. You can use "/" to separate namespaces and create virtual folders in the menu.
Ok, I added the mtime handling and squashed the commit so its nice and mergable :) |
Awesome, thanks. :) When testing,
Also, I don't use the global ssh_config on my machine but mine's located at |
You're right, there was a bug in the |
Build menu items based on .ssh/config
👍 Thanks!! |
This is the first proposal for #14 to include all hosts that are already configured in the ssh config file. Currently namespaces identified with "/" are not supported.
Let's discuss.