Bugfix/metrics-warning #82
Conversation
|
Docs were not updated because I don't believe this change should affect the current docs based on what I saw in the docs. But happy to update if mistaken. |
There was a problem hiding this comment.
@fivetran-sheringuyen I just tested this on both 1.4 and 1.3 dbt core versions and it works as expected with the warning removed! My only request/question is that we should update the metrics version note in the README (see below)
This should be greater than 1.3.0 I believe. Additionally, is there anything we need to add for version requirements with the dbt metrics package?
|
@fivetran-sheringuyen before we release this, let's make sure we integrate PR #81 into the v0.2.1 release. I would rather batch these updates than do back to back minor releases. |
|
|
||
| ## Bug Fixes | ||
| - Enabling additional Snapchat Ads columns in `ad_reporting__url_report` that were previously mapped to null values. ([#81](https://github.com/fivetran/dbt_ad_reporting/pull/81)) | ||
| - These columns are: ad_group_id (ad_squad_id), ad_group_name (ad_squad_name), campaign_id and campaign_name. |
There was a problem hiding this comment.
I would just instead note that campaign id and name were dropped from the mapping
Are you a current Fivetran customer?
Fivetran Employee 🥨
What change(s) does this PR introduce?
Updates to
ad_reporting_metrics.ymlin order to stop warnings when running package.Did you update the CHANGELOG?
Does this PR introduce a breaking change?
It currently looks like this update should work for both dbt-core 1.3+ according to dbt docs.
Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
Is this PR in response to a previously created Bug or Feature Request
How did you test the PR changes?
Select which warehouse(s) were used to test the PR
Provide an emoji that best describes your current mood
🍳
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.