fix(): add correct variable name in ad_reporting__url_report
#96
Conversation
There was a problem hiding this comment.
@aleix-cd thanks for catching this! I have just a few small requests to add to the CHANGELOG and bump the version as I will merge this into our upcoming v1.5.0 release which is slated to be released in the current sprint.
Once those changes are applied I will merge this in the release branch. Thanks again!
There was a problem hiding this comment.
@aleix-cd thanks for making the updates! All looks good to merge into the release branch.
We are still waiting on finishing our Amazon Ads and TikTok Ads updates, but they should be done and included in the release branch by mid next week. You can expect to see this included in that release. Thanks again for contributing to the package and helping catch this bug 😄
Please provide your name and company
Aleix, Capdesk from Carta
Link the issue/feature request which this PR is meant to address
#95
Detail what changes this PR introduces and how this addresses the issue/feature request linked above.
Small change in
models/ad_reporting__url_report.sql, where the variable name referenced in line 33 was not correct.How did you validate the changes introduced within this PR?
Locally, pointing the dbt package of a project to my fork
Which warehouse did you use to develop these changes?
Snowflake
Did you update the CHANGELOG?
Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
Provide an emoji that best describes your current mood
🚀