Skip to content

Commit

Permalink
Merge pull request #96 from aleix-cd/fix/var-name-url-report
Browse files Browse the repository at this point in the history
fix(): add correct variable name in `ad_reporting__url_report`
  • Loading branch information
fivetran-joemarkiewicz authored Jul 20, 2023
2 parents cb0738c + 82b98db commit 640764e
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 3 deletions.
8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
# dbt_ad_reporting v1.5.0

## Bug Fixes
- Adding the correct variable name in `ad_reporting__url_report` for passthrough metrics. ([PR #96](https://github.com/fivetran/dbt_ad_reporting/pull/96))

## Contributors
- [@aleix-cd](https://github.com/aleix-cd) ([PR #96](https://github.com/fivetran/dbt_ad_reporting/pull/96))

# dbt_ad_reporting v1.4.0

## 🎉 Feature Enhancement 🎉
Expand Down
2 changes: 1 addition & 1 deletion dbt_project.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: 'ad_reporting'
version: '1.4.0'
version: '1.5.0'

config-version: 2

Expand Down
2 changes: 1 addition & 1 deletion integration_tests/dbt_project.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: 'ad_reporting_integration_tests'
version: '1.4.0'
version: '1.5.0'
profile: 'integration_tests'
config-version: 2

Expand Down
2 changes: 1 addition & 1 deletion models/ad_reporting__url_report.sql
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ aggregated as (
sum(impressions) as impressions,
sum(spend) as spend

{{ fivetran_utils.persist_pass_through_columns(pass_through_variable='ad_reporting__url_passthrough_metrics', transform = 'sum') }}
{{ fivetran_utils.persist_pass_through_columns(pass_through_variable='ad_reporting__ad_passthrough_metrics', transform = 'sum') }}

from base
{{ dbt_utils.group_by(16) }}
Expand Down

0 comments on commit 640764e

Please sign in to comment.