Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readme update #25

Merged
merged 5 commits into from
May 20, 2021
Merged

Conversation

fivetran-joemarkiewicz
Copy link
Contributor

This PR includes the following updates:

  • Added description to the Daily Issue Field History Columns section to specify the column values to be added to the variable are from the field_name field.
    • FYI the list variables are no longer case sensitive as a result of a previous release.

Copy link
Contributor

@fivetran-jamie fivetran-jamie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i forget - did we decide to keep using field names?

@fivetran-jamie
Copy link
Contributor

or there was the issue with special-character column names...

README.md Outdated Show resolved Hide resolved
@@ -26,9 +26,9 @@ limit_to_relevant_fields as (
from combined_field_histories

where
lower(field_name) in ('sprint', 'status'
lower(field_id) in ('sprint', 'status'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in our data sprint has a custom field ID (instead of sprint it's customfield_10020)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch @fivetran-jamie! I just pushed a new commit that accommodates for the sprint field being custom. Let me know if you have any questions. The solution is pretty basic, but works as intended!

max(case when lower(field_name) = 'status' then field_value end) as status,
max(case when lower(field_name) = 'sprint' then field_value end) as sprint
max(case when lower(field_id) = 'status' then field_value end) as status,
max(case when lower(field_id) = 'sprint' then field_value end) as sprint
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sprint has a custom field_id

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above

fivetran-joemarkiewicz and others added 3 commits May 18, 2021 16:27
Co-authored-by: Jamie Rodriguez <65564846+fivetran-jamie@users.noreply.github.com>
Copy link
Contributor

@fivetran-jamie fivetran-jamie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants