Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jm updates #8

Merged
merged 4 commits into from
Mar 17, 2021
Merged

Jm updates #8

merged 4 commits into from
Mar 17, 2021

Conversation

fivetran-joemarkiewicz
Copy link
Contributor

This PR includes the following updates:

  • Breaking change consisting of renaming models to be consistent with current Fivetran best practices
  • Custom schema compatibility
  • CircleCi integration
  • Github Pages docs creation
  • Updates which address Issue improvements #5 and Issue Invoice Line Item is not guaranteed to be unique #3
  • Version upgrade from v0.2.1 -> v0.3.0 as this release will include breaking changes
  • Documentation updates

invoice.amount_remaining,
invoice.attempt_count,
invoice.description as invoice_memo,
invoice_line_item.unique_id as invoice_line_item_id,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This update was to reflect bug noticed by Issue #3

Comment on lines +56 to +57
invoice_line_item.period_start,
invoice_line_item.period_end,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This update was to reflect enhancement noted in Issue #5

@fivetran-joemarkiewicz
Copy link
Contributor Author

Will want to add final model field name changes to release notes

Copy link
Contributor

@kristin-bagnall kristin-bagnall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change suggestions, otherwise looks good!

echo `pwd`
cd integration_tests
dbt deps
dbt seed --target bigquery
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
dbt seed --target bigquery
dbt seed --target bigquery --full-refresh

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

dbt_project.yml Outdated

require-dbt-version: [">=0.18.0", "<0.20.0"]

models:
stripe:
+schema: _stripe
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
+schema: _stripe
+schema: stripe

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@fivetran-joemarkiewicz fivetran-joemarkiewicz merged commit dfb2766 into master Mar 17, 2021
@fivetran-joemarkiewicz fivetran-joemarkiewicz deleted the jm-updates branch March 17, 2021 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants