pack.sh, *.asd: change commented-out :version lines, comment them out #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pack.sh: previously, pack.sh would change a line like :version "$VERSION" to :version "0.1.5" (or whatever the version actually is). Now, it looks for a commented-out line of the same code, and does the same substitution while uncommenting the code. This lets you keep the line with "$VERSION$", which is not a valid version, commented out, while not running afoul of introspection tools (e.g., uiop/utility:parse-version). *.asd: comment out :version lines to work with this new pack.sh
|
Clever. Thanks for the patch. |
fjolliton
added a commit
that referenced
this pull request
Mar 24, 2015
pack.sh, *.asd: change commented-out :version lines, comment them out
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the issue
#2
Commit log:
pack.sh: previously, pack.sh would change a line like
:version "$VERSION"
to
:version "0.1.5"
(or whatever the version actually is). Now, it looks for a
commented-out line of the same code, and does the same substitution
while uncommenting the code.
This lets you keep the line with "$VERSION$", which is not a valid
version, commented out, while not running afoul of introspection tools
(e.g., uiop/utility:parse-version).
*.asd: comment out :version lines to work with this new pack.sh