-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
タグ別のユーザーページにおいて「休会」と「退会」ユーザーが表示されない仕様に統一 #7089
Merged
komagata
merged 3 commits into
main
from
bug/exclude-hibernated-and-retired-users-from-users-list-by-tag
Dec 31, 2023
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
users/tags
ページ上のユーザーアイコンの検索・アサーションでは、「ターゲットとなるユーザーが、このページ上の他のタグにも属している」という可能性を考えると、within
などで「ギター」タグのユーザー一覧の中にスコープを絞ってアイコン検索するようにした方がいいかなと考えましたが、いかがでしょうか?👀There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@junohm410
※お先にコメントのご返信のみ失礼いたします><!
CircleCIが通りましたら別途「ご確認をお願いいたします」とご連絡しますので、
その後確認をいただけますと幸いです🙏
ご提案ありがとうございます🙇♀️
HTMLの構造上、特定のタグ名とタグに属するアイコンに共通するセレクタを指定するのが難しそうに感じたのでアプローチを変更いたしました🙇♀️
ser.tags.where.not(name: tag_name).destroy_all
によりアプリ内で「ギター」タグのみを残すことで、「ギター」タグのみに対して表示を確認できるようにしております🙏
ここでテストしたいのはタグ別ページにおいて「休会と退会ユーザーが表示されなくなること」なので、
ターゲットとなる「ギター」以外のタグをページに残した状態でテストを行う必要がない(=
kensyu
が登録している「ギター」タグのみ表示し、テストできれば良い)のではないかと判断いたしました🙏参考にさせていただいた記事:
【minitest / RSpec】繰り返し表示されている要素の中から「これ」という1件を選んで検証する方法あれこれ #Rails - Qiita
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ご修正ありがとうございます!
ご説明やURLを拝読しあらためて実際のHTML要素もみたところ、
within
では解決しにくい問題でしたね🙇♂️こちらはすみませんでした🙏ギタータグ以外のタグ登録を消去して、今回検証したい「ギター」に対し、
kensyu
が属するか否かを確実に確認するという方針について、把握しました!大変勉強になりました🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@junohm410
ご確認ありがとうございます🙇♀️
とんでもないです!!HTML要素まで見ていただき恐れ入ります🙏
「対象を絞る」という視点が不足していたので、大事な点をご教示いただきこちらこそ大変勉強になりました!
ありがとうございます🙇♀️