Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize names and arguments for Composite's mergeReqs and mergeModel #114

Merged
merged 5 commits into from
Apr 11, 2022

Conversation

fjvallarino
Copy link
Owner

@fjvallarino fjvallarino commented Apr 11, 2022

These changes were made for consistency and to allow the same use cases as with regular widgets.

  • Renamed:
    • customModelBuilder -> compositeMergeModel
    • CompositeCustomModelBuilder -> MergeModelHandler.
  • Added
    • compositeMergeEvents
  • Changed
    • compositeMergeModel (previously customModelBuilder) now receives WidgetEnv as its first parameter.
    • compositeMergeReqs now receives parentModel and oldModel too.

Note: compositeMergeModel does not receive the node and oldNode because node is created using the model, and oldNode may not exist when invoked during onInit.

@fjvallarino fjvallarino merged commit fc40e2e into main Apr 11, 2022
@fjvallarino fjvallarino deleted the chore/composite-improvements branch April 11, 2022 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant