Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu out of bounds with animation bug fix #188

Conversation

JelianRadoev
Copy link

Before submitting a pull request, please make sure the following is done:

  1. Fork the repository and create your branch from master.
  2. Run yarn in the repository root.
  3. If you've fixed a bug or added code that should be tested, add tests!
  4. Run yarn start in the example folder to test your changes.
  5. Ensure the test suite passes (yarn test). It uses the example
  6. Update the readme if needed or the documentation
  7. Update the typescript definition is needed
  8. Make sure your code lints (yarn lint --fix).

Learn more about contributing here

selector for animation doesn't have any effect (guess Menu component has to be rerendered in order to work)
also if default is none tests cannot propely pass with using animation in real scenario
@fkhadra
Copy link
Owner

fkhadra commented Nov 3, 2022

Hey @JelianRadoev, sorry for responding so late, I wasn't able to work on the lib for a long time. Now I'm back on track. This issue is addressed in the upcoming release #220. Sorry again and thank you for your contribution 🙏🏽

@fkhadra fkhadra closed this Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants