New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v6.0.0 #220
Conversation
Preventing default on keydown causes all inputs on the page to stop working whilst the Menu component is mounted. Some apps have the menu mounted whilst not in use, causing inputs to stop working. Adds a flag to disable this feature and also makes it work as intended only for keys required for operating the menu that may cause the window to scroll. Related issue #168
Solv: Add support for hidden predicate to Separator.
Remove MenuProvider from README
add: prop to disable boundaries check
Pass item id to `onClick()` handler and `hidden`/`disabled` predicates
Make preventing default on keydown optional - Fixes #168
Hey @ttay24 , thanks for using it. You can expect a release in the coming days, maybe later tonight if I'm able to finish what I have planned. |
hi @fkhadra, a couple of questions if you don't mind: 1- Why did you removed "onShown" and "onHidden" callbacks ? 2- What are the new alternatives to know/react when the menu is shown or hidden? Thanks |
check this: https://fkhadra.github.io/react-contexify/track-menu-visibility |
Breaking changes
theme
andanimation
. Better DX now thanks to typescriptonShown
and onHidden`useContext.show
andcontextMenu.show