pauseOnFocusLoss is not applied to windows already unfocused. #541
Assignees
Labels
Merged in next
Merged but not live
Comments
|
Hello @AdrienLemaire this will be fixed in the next release. Thanks for reporting |
Merged
fkhadra
added a commit
that referenced
this issue
Dec 29, 2020
fkhadra
added a commit
that referenced
this issue
Jan 25, 2021
## 💥 Breaking changes - dependency to react-transition-group has been removed #514 - the `duration` parameter has been removed from `cssTransition`. Css animations just works now out of the box. Check the codesanbox below - the border-radius has been increased a bit ## 🚀 Features - Css animation just works! [](https://codesandbox.io/s/react-toastify-animatecss-jxrx9?fontsize=14&hidenavigation=1&theme=dark&view=preview) - add a way to load the CSS without a CSS loader [](https://codesandbox.io/s/react-toastify-inject-style-qfg0l?fontsize=14&hidenavigation=1&theme=dark) - specify swipe direction, close #512 . Thanks to @denydavy [](https://codesandbox.io/s/react-toastify-drag-y-lh88i?fontsize=14&hidenavigation=1&theme=dark) - bundle size reduced from ~7k to ~5k! - remove the dependency on prop-types. ## 🐛 Bugfix - fix #541 apply pauseOnFocusLoss on first render - fix #538 react-dom should be a peer dep - fix #530 change id generation - fix #534 #483 toastId cannot be reused - fix #511 by removing react-transition-group - fix #550 Unable to select text inside inputs when a toast is open - fix #555 The toast timer starts after you click on the toast
This was referenced Mar 17, 2021
](https://codesandbox.io/s/react-toastify-animatecss-jxrx9?fontsize=14&hidenavigation=1&theme=dark&view=preview){kind=link}
](https://codesandbox.io/s/react-toastify-inject-style-qfg0l?fontsize=14&hidenavigation=1&theme=dark){kind=link}
](https://codesandbox.io/s/react-toastify-drag-y-lh88i?fontsize=14&hidenavigation=1&theme=dark){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Do you want to request a feature or report a bug?
Bug
What is the current behavior?
When a notification is triggered, already unfocused windows will see the notification play.
Receiving notifications while not already focusing the page can happen with websocket subscriptions for example.
video example
If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem. Your bug will get fixed much faster if we can run your code and it doesn't have dependencies other than React. Paste the link to your CodeSandbox (https://codesandbox.io/s/new) example below:
Here you go. Please unfocus the window within 3 secs after opening the page
https://codesandbox.io/s/cocky-keldysh-6yc7o?file=/src/App.js
What is the expected behavior?
Notifications should be paused until the window gets focused
Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React?
I believe the bug affects all versions and browsers, but didn't verify.
Using react concurrent and react toastify 6.1.0, and reproduced the bug with codesandbox using react 17
The text was updated successfully, but these errors were encountered: