Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better redux example #290

Closed
wants to merge 1 commit into from
Closed

Better redux example #290

wants to merge 1 commit into from

Conversation

levino
Copy link
Contributor

@levino levino commented Dec 11, 2018

Fix #283.

Potentially you want to fork my codesandbox again under your own account and use this. I do not guarantuee that I will maintain it.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.129% when pulling eabf52e on Levino:patch-1 into de462b3 on fkhadra:master.

@levino
Copy link
Contributor Author

levino commented Dec 14, 2018

I guess this should be merged, no?

@fkhadra
Copy link
Owner

fkhadra commented Dec 14, 2018

Sure it's approved. I plan to release the next version during this weekend or maybe Monday

@levino
Copy link
Contributor Author

levino commented Dec 15, 2018

Then leave the issue open. It will be closed automatically when you merge this pull request.

@fkhadra
Copy link
Owner

fkhadra commented Dec 15, 2018

Hello @levino,

I forked the sandbox and putted you as commit author: a822cea

@fkhadra fkhadra closed this Dec 15, 2018
@levino
Copy link
Contributor Author

levino commented Dec 15, 2018

Fine with me. Thanks for the credit.

@fkhadra
Copy link
Owner

fkhadra commented Dec 15, 2018

You're welcome. Enjoy the rest of the weekend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants